-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add v0.47.15 and v0.50.11 changelog to main #22911
Conversation
📝 WalkthroughWalkthroughThis pull request involves updates to the Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
errors/CHANGELOG.md (2)
38-38
: Improve conciseness of the explanationThe explanation could be more concise while maintaining clarity.
-Remove Grpc error codes from the error package. This is done in order to keep the dependency graph of errors minimal +Remove Grpc error codes from the error package to minimize the dependency graph🧰 Tools
🪛 LanguageTool
[style] ~38-~38: Consider a shorter alternative to avoid wordiness.
Context: ...es from the error package. This is done in order to keep the dependency graph of errors min...(IN_ORDER_TO_PREMIUM)
39-39
: Consider enhancing migration guidanceWhile the migration path is mentioned, it would be helpful to structure it more clearly for developers.
-Removes `IsOf`, `Recover`, `WithType` and wrapped error. The errors package uses the go std library errors. It provides a `Wrap` and `Wrapf` to help in the migration from v1 to v2. +Removes the following functions in favor of Go's standard library errors: +* `IsOf` +* `Recover` +* `WithType` +* wrapped error + +Migration path: +* Use the provided `Wrap` and `Wrapf` functions for error wrapping +* Use `errors.Is` and `errors.As` from the standard library for error checkingCHANGELOG.md (2)
809-812
: Security advisory should include CVE identifier if availableThe security fix for ABS-0043/ABS-0044 should ideally include the CVE identifier if one was assigned, to help users track and reference the vulnerability.
57-57
: Consider adding release date to unreleased sectionThe unreleased section should include an estimated target release date to help users plan for upcoming changes.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
CHANGELOG.md
(3 hunks)errors/CHANGELOG.md
(1 hunks)errors/go.mod
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- errors/go.mod
🧰 Additional context used
📓 Path-based instructions (2)
errors/CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
CHANGELOG.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🪛 LanguageTool
errors/CHANGELOG.md
[style] ~38-~38: Consider a shorter alternative to avoid wordiness.
Context: ...es from the error package. This is done in order to keep the dependency graph of errors min...
(IN_ORDER_TO_PREMIUM)
🔇 Additional comments (2)
errors/CHANGELOG.md (1)
34-36
: LGTM! Version header is well-formatted
The version header follows the Keep a Changelog format and includes a proper link to the release.
CHANGELOG.md (1)
Line range hint 1-813
: LGTM! The changelog follows best practices for documentation
The changelog is well-structured with:
- Consistent formatting and categorization
- Clear PR references
- Detailed descriptions of changes
- Proper semantic versioning
- Security fixes clearly highlighted
Description
Release chores.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation